Fixes PHP 8.4 deprecation warnings #217
Open
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the "Implicitly marking parameter $context as nullable is deprecated" deprecation
freost
changed the title
aldilop
approved these changes
Dec 4, 2024
Contributor
|
Any downsides will accepting this PR and publishing a new version? |
Contributor
|
PHP 8.4 adoption is growing, so it would be nice to have support for it, @cebe . I obviously have the same issue with PHP 8.5 as well. |
Contributor
|
Maybe if you don’t have time (which is totally understandable, since you’re spending your free time on open source), you could add another maintainer to help? There seems to be many open PR's and Issues. |
Contributor
|
Another maintainer would be better than a fork. If B/C is an issue, what about releasing a 2.0 with only PHP 8.4+ and the latest of the libraries? A quick rector pass would also make the code more maintainable because static analysis is so much better with the later versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the "Implicitly marking parameter ... as nullable is deprecated" deprecation warnings